Version Update of HapCUT2 and Restructuring of XML file #5975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgruening
reviewed
Apr 29, 2024
tools/hapcut2/hapcut2.xml
Outdated
| @@ -262,7 +218,7 @@ See `HapCUT2 on GitHib <https://github.com/vibansal/HapCUT2>`_ for more detailed | |||
|
|
|||
| .. class:: infomark | |||
|
|
|||
| Quickmerge was wrapped by the Galaxy Australia team. | |||
| HapCUT2 was wrapped by the Galaxy Australia team. | |||
There was a problem hiding this comment.
We should replace that with a proper creator tag.
There was a problem hiding this comment.
Replaced the above with creator tag in macros 👍
bgruening
approved these changes
Apr 30, 2024
|
Thanks for the upgrades @SaimMomin12 I trust your judgement 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FOR CONTRIBUTOR:
Hi,
This PR is based on #5971 for updating the HapCUT2. Tool XML was restructured and necessary minor changes were made as per the version update.
PS: @neoformit Would you like to have a look at the changes made by me, since you worked on wrapping this tool?
Cheers,
Saim