Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated FASTK tool wrapper #5965

Merged
merged 8 commits into from
May 3, 2024
Merged

Updated FASTK tool wrapper #5965

merged 8 commits into from
May 3, 2024

Conversation

SaimMomin12
Copy link
Contributor

@SaimMomin12 SaimMomin12 commented Apr 23, 2024

FOR CONTRIBUTOR:

  • I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • License permits unrestricted use (educational + commercial)
  • This PR adds a new tool or tool collection
  • This PR updates an existing tool or tool collection
  • This PR does something else (explain below)

Hi,

Based on the last FASTK tool wrapper developed by @abueg in #5550 I have made necessary changes and updated the wrapper. The idea forward would be to create standalone suite of tools (Logex,Histex,etc) that exist within FASTK.

Best,
Saim

tools/fastk/.shed.yml Show resolved Hide resolved
tools/fastk/fastk.xml Outdated Show resolved Hide resolved
tools/fastk/fastk.xml Outdated Show resolved Hide resolved
tools/fastk/fastk.xml Outdated Show resolved Hide resolved
tools/fastk/fastk.xml Outdated Show resolved Hide resolved
@bernt-matthias bernt-matthias mentioned this pull request Apr 23, 2024
5 tasks
@bgruening
Copy link
Member

Other than fixing the shed.yml I think the first tool is read to be shipped.

tools/fastk/fastk.xml Outdated Show resolved Hide resolved
tools/fastk/fastk.xml Outdated Show resolved Hide resolved
tools/fastk/fastk.xml Outdated Show resolved Hide resolved
tools/fastk/fastk.xml Show resolved Hide resolved
@abueg abueg mentioned this pull request May 1, 2024
@SaimMomin12 SaimMomin12 requested a review from bernt-matthias May 3, 2024 13:09
Copy link
Contributor

@bernt-matthias bernt-matthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the small change to the help this looks good to go from my side. Thanks a lot to all who contributed.

@bgruening bgruening merged commit 57fa4dc into galaxyproject:main May 3, 2024
11 checks passed
@bgruening
Copy link
Member

Thanks, everyone!

@astrovsky01
Copy link
Contributor

@SaimMomin12 for downstream tools, the hidden ktab files are required, and a consistent naming schema is also important. Would it be possible to add those into the output structure?

@SaimMomin12
Copy link
Contributor Author

Hi @astrovsky01, yes the earlier day I realized that the ktab files are necessary while I was working on Logex tool. I will figure out a way to retain these files and update the wrapper accordingly.

@SaimMomin12 SaimMomin12 deleted the FASTK branch May 14, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants