Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating tools/cnvkit from version 0.9.10 to 0.9.11 #5961

Merged
merged 3 commits into from
Apr 22, 2024

Conversation

gxydevbot
Copy link
Collaborator

Hello! This is an automated update of the following tool: tools/cnvkit. I created this PR because I think the tool's main dependency is out of date, i.e. there is a newer version available through conda.

I have updated tools/cnvkit from version 0.9.10 to 0.9.11.

Project home page: https://github.com/etal/cnvkit/releases

For any comments, queries or criticism about the bot, not related to the tool being updated in this PR, please create an issue here.

@bgruening
Copy link
Member

@khaled196 do you want to have a look here?

@khaled196
Copy link
Contributor

Hi @bgruening

I found the problem but how can I fix it? shall. I create a pull request for the original directory

The issue concerns the difference between the new version output data and the repo test data.

It can be solved by replacing


<output name="out_reference_cnn" file="reference.cnn" />

to 

<output name="out_reference_cnn" file="reference.cnn" ftype="tabular" compare="sim_size">
    <assert_contents><has_size value="3000" delta="2000" /></assert_contents>
</output>

In test 1 and test 2

@bgruening
Copy link
Member

You can create a completely new PR or PR to the bots repo as you like. A new PR is easier and totally fine.

fix refence.cnn file difference
@bgruening
Copy link
Member

Missed the PR this is very nice. Thanks @khaled196!

Are you already using the https://github.com/galaxyproject/galaxy-language-server ?

@khaled196
Copy link
Contributor

@bgruening

This is the first to know about it. I used GitPod. However. this looks more specific to the galaxy.

Thanks for sharing this. I will be using this for future work

@bgruening
Copy link
Member

Thanks for sharing this. I will be using this for future work

Cool, it will make your life easier for sure :)

@bgruening bgruening enabled auto-merge (squash) April 22, 2024 17:27
@bgruening bgruening merged commit bced16a into galaxyproject:main Apr 22, 2024
14 checks passed
@bgruening bgruening deleted the tools/cnvkit branch April 22, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants