Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Funannotate: fix for missing env var #5276

Merged
merged 2 commits into from
Apr 25, 2023

Conversation

abretaud
Copy link
Contributor

FOR CONTRIBUTOR:

  • - I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • - License permits unrestricted use (educational + commercial)
  • - This PR adds a new tool or tool collection
  • - This PR updates an existing tool or tool collection
  • - This PR does something else (explain below)

Fill an env var needed by some subprocess. Problem reported upstream in nextgenusfs/funannotate#905

Copy link
Contributor

@bernt-matthias bernt-matthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just wondering if its possible to add a test case that would fail wo the env variable. This would allow us to more confidently remove the env variable again once its fixed upstream.

If not I'm fine with merging.

@abretaud
Copy link
Contributor Author

Arf, it would be painful to create the data for a test case here, but I'm preparing a worflow test in GTN that should test this situation

@bernt-matthias
Copy link
Contributor

I'm preparing a worflow test in GTN that should test this situation

Good enough for me :)

Lets merge

@bernt-matthias bernt-matthias merged commit 2c4f817 into galaxyproject:main Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants