Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating tools/bwameth from version 0.2.6 to 0.2.7 #5262

Merged
merged 5 commits into from
Jun 2, 2024

Conversation

planemo-autoupdate
Copy link
Contributor

Hello! This is an automated update of the following tool: tools/bwameth. I created this PR because I think the tool's main dependency is out of date, i.e. there is a newer version available through conda.

I have updated tools/bwameth from version 0.2.6 to 0.2.7.

Project home page: https://github.com/brentp/bwa-meth/releases

For any comments, queries or criticism about the bot, not related to the tool being updated in this PR, please create an issue here.

@bgruening bgruening requested a review from bernt-matthias May 19, 2024 08:21
@@ -78,7 +78,8 @@ bwameth.py
#else:
$read1 $read2
#end if
| samtools view --no-PG -u - | samtools sort --no-PG -@ "\${GALAXY_SLOTS:-4}" -T "\${TMPDIR:-.}" -O bam -o output.bam -
| samtools sort -@\${GALAXY_SLOTS:-4} -T "\${TMPDIR:-.}" -O bam -o output.bam
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please undo this change and maybe add the explanation from here

## Convert SAM output to sorted BAM

Maybe use exactly the command line from over there:

| samtools sort --no-PG -l 0 -T "\${TMPDIR:-.}" -O bam | samtools view --no-PG -O bam -@ \${GALAXY_SLOTS:-1} -o output.bam

@bgruening
Copy link
Member

I did, but now I have sort: unrecognized option '--no-PG'

@bernt-matthias
Copy link
Contributor

I did, but now I have sort: unrecognized option '--no-PG'

Might bwameth come with a very old samtools version?

Anyway, maybe we should remove it anyway, we recently came to the conclusion that we should not use it: #5985 (comment)

@bernt-matthias
Copy link
Contributor

Can we easily find out which samtools verison is used here? bioconda seems to have no pinning on samtools. I would expect something recent .. seems fishy.

@bgruening
Copy link
Member

(planemo) bag@bag:~/projects/code/tools-iuc/tools/jbrowse2$ docker run -i -t --rm quay.io/biocontainers/bwameth:0.2.7--pyh7cba7a3_0 bash
root@3b599841503d:/# samtools --version
samtools 1.6
Using htslib 1.6
Copyright (C) 2017 Genome Research Ltd.

Copy link
Contributor

@bernt-matthias bernt-matthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you like we can proceed.

samtools 1.6 is 7 years old (container only 1 year) if we want something newer we could bump the container, but this would delay things here.

Up to you :)

@bgruening
Copy link
Member

I tried, but realisticially will not have time to work on this "tab" in the next month.

@bgruening bgruening merged commit 16f1bd9 into galaxyproject:main Jun 2, 2024
11 checks passed
@bgruening bgruening deleted the tools/bwameth branch June 2, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants