-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating tools/bwameth from version 0.2.6 to 0.2.7 #5262
Updating tools/bwameth from version 0.2.6 to 0.2.7 #5262
Conversation
tools/bwameth/bwameth.xml
Outdated
@@ -78,7 +78,8 @@ bwameth.py | |||
#else: | |||
$read1 $read2 | |||
#end if | |||
| samtools view --no-PG -u - | samtools sort --no-PG -@ "\${GALAXY_SLOTS:-4}" -T "\${TMPDIR:-.}" -O bam -o output.bam - | |||
| samtools sort -@\${GALAXY_SLOTS:-4} -T "\${TMPDIR:-.}" -O bam -o output.bam |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please undo this change and maybe add the explanation from here
tools-iuc/tools/hisat2/hisat2.xml
Line 341 in 3e7bf5a
## Convert SAM output to sorted BAM |
Maybe use exactly the command line from over there:
| samtools sort --no-PG -l 0 -T "\${TMPDIR:-.}" -O bam | samtools view --no-PG -O bam -@ \${GALAXY_SLOTS:-1} -o output.bam
I did, but now I have |
Might bwameth come with a very old samtools version? Anyway, maybe we should remove it anyway, we recently came to the conclusion that we should not use it: #5985 (comment) |
Can we easily find out which samtools verison is used here? bioconda seems to have no pinning on samtools. I would expect something recent .. seems fishy. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you like we can proceed.
samtools 1.6 is 7 years old (container only 1 year) if we want something newer we could bump the container, but this would delay things here.
Up to you :)
I tried, but realisticially will not have time to work on this "tab" in the next month. |
Hello! This is an automated update of the following tool: tools/bwameth. I created this PR because I think the tool's main dependency is out of date, i.e. there is a newer version available through conda.
I have updated tools/bwameth from version 0.2.6 to 0.2.7.
Project home page: https://github.com/brentp/bwa-meth/releases
For any comments, queries or criticism about the bot, not related to the tool being updated in this PR, please create an issue here.