Circos and PR workflow fixes

[bernt-matthias]

FOR CONTRIBUTOR:

• - I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
• - License permits unrestricted use (educational + commercial)
• - This PR adds a new tool or tool collection
• - This PR updates an existing tool or tool collection
• - This PR does something else (explain below)

[bernt-matthias]

I think you also need to change line 319 above

Lets try :) Thanks for the suggestion.

Wondering if it might be a solution to forbid skipped here

tools-iuc/.github/workflows/pr.yaml

Line 432 in 1d443e7

if: ${{ needs.combine_outputs.result != 'success' && needs.combine_outputs.result != 'skipped' }}

(and maybe in all other tasks of this job except for the file size task).

Somehow I remember that we added this only to allow for PR that do not change tools .. but this might be better solved by #5219

[bernt-matthias]

xref 4cc19b2

[hexylena]

looks fine for me

[wm75]

Somehow I remember that we added this only to allow for PR that do not change tools .. but this might be better solved by #5219

Not quite, I'm afraid. #5219 only serves as a shortcut for obvious cases of "no tool can possibly be affected by this". You can still have changes witihin tool directories that are not supposed to trigger tests. So #5219 can act as a prefilter that gets simple cases out of the way fast, but you still need the more fine-grained logic of the planemo action for everything that passes that first check.

[bernt-matthias]

You can still have changes witihin tool directories that are not supposed to trigger tests.

Do you have an example?

[wm75]

You can still have changes witihin tool directories that are not supposed to trigger tests.

Do you have an example?

Currently, the only example is changes to tools listed in .tt_skip.
Was thinking that tools without a shed.yml file would be another case, but those cause a failure, not a skipped test.

If we are talking about any skipped steps, not just planemo testing, something I'd like to implement soonish is skipping R linting when no R-related files have been touched.

[bernt-matthias]

And the last question before merging: should we bump? I would say no...