Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make guppyplex input handling more flexible #4353

Merged
merged 6 commits into from
Jan 31, 2022

Conversation

wm75
Copy link
Contributor

@wm75 wm75 commented Jan 27, 2022

This allows the user to specify which sequence input files guppyplex
should collapse into a single output, and which ones it should keep
separate. Also makes the tool work with fastq and fastq.gz data alike
and exposes the --quality threshold parameter.

The changeset also contains a fix for the artic minion pipeline, which
should make it handle input data with spaces in its name.

FOR CONTRIBUTOR:

  • - I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • - License permits unrestricted use (educational + commercial)
  • - This PR adds a new tool or tool collection
  • - This PR updates an existing tool or tool collection
  • - This PR does something else (explain below)

This allows the user to specify which sequence input files guppyplex
should collapse into a single output, and which ones it should keep
separate. Also makes the tool work with fastq and fastq.gz data alike
and exposes the --quality threshold parameter.

The changeset also contains a fix for the artic minion pipeline, which
should make it handle input data with spaces in its name.
@wm75
Copy link
Contributor Author

wm75 commented Jan 27, 2022

Currently I cannot fully test this locally because my conda fails to resolve the bioconda artic package's dependencies.
Curious to see whether that will work here.

@pvanheus
Copy link
Contributor

Currently I cannot fully test this locally because my conda fails to resolve the bioconda artic package's dependencies. Curious to see whether that will work here.

The artic bioconda package is rather huge, and best installed with mamba. (We have actually switched to using Singularity in Galaxy to a large extent because of this package!)

@wm75
Copy link
Contributor Author

wm75 commented Jan 27, 2022

Currently I cannot fully test this locally because my conda fails to resolve the bioconda artic package's dependencies. Curious to see whether that will work here.

The artic bioconda package is rather huge, and best installed with mamba. (We have actually switched to using Singularity in Galaxy to a large extent because of this package!)

I'm impressed: conda chewed on this for hours without success before I killed it. mamba resolved things in under 30 secs!
Thanks for the hint @pvanheus !

wm75 added 2 commits January 27, 2022 16:58
Since the wrapper has to symlink each input file separately it could
generate a very long command line when there are lots of files to
concatenate.
@wm75 wm75 changed the title [WIP] Make guppyplex input handling more flexible Make guppyplex input handling more flexible Jan 27, 2022
@bgruening bgruening merged commit e6a1f82 into galaxyproject:master Jan 31, 2022
@bernt-matthias bernt-matthias mentioned this pull request Aug 19, 2022
59 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants