Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

featurecounts: fix unused parameters #4232

Conversation

bernt-matthias
Copy link
Contributor

tool defined a parameter --countSplitAlignmentsOnly that was unused in
the command section. Even worse such a parameter does not exist on the
CLI, but:

  --splitOnly         Count split alignments only (ie. alignments with CIGAR
                      string containing 'N'). An example of split alignments is
                      exon-spanning reads in RNA-seq data.

  --nonSplitOnly      If specified, only non-split alignments (CIGAR strings do
                      not contain letter 'N') will be counted. All the other
                      alignments will be ignored.

this has been fixed.

Furthermore some parameters from the large Advanced options section
have been moved to a new Read filtering options section (as suggested
by the nice featureCounts help output).

FOR CONTRIBUTOR:

  • - I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • - License permits unrestricted use (educational + commercial)
  • - This PR adds a new tool or tool collection
  • - This PR updates an existing tool or tool collection
  • - This PR does something else (explain below)

tool defined a parameter `--countSplitAlignmentsOnly` that was unused in
the command section. Even worse such a parameter does not exist on the
CLI, but:

```
  --splitOnly         Count split alignments only (ie. alignments with CIGAR
                      string containing 'N'). An example of split alignments is
                      exon-spanning reads in RNA-seq data.

  --nonSplitOnly      If specified, only non-split alignments (CIGAR strings do
                      not contain letter 'N') will be counted. All the other
                      alignments will be ignored.
```

this has been fixed.

Furthermore some parameters from the large `Advanced options` section
have been moved to a new `Read filtering options` section (as suggested
by the nice featureCounts help output).
@bernt-matthias bernt-matthias mentioned this pull request Nov 25, 2021
59 tasks
@bgruening bgruening merged commit 839f962 into galaxyproject:master Dec 4, 2021
@bernt-matthias bernt-matthias deleted the topic/featurecounts-unused-param branch March 14, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants