Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cutadapt: add missing arguments and remove unsued test params #4195

Merged
merged 3 commits into from
Nov 27, 2021

Conversation

bernt-matthias
Copy link
Contributor

@bernt-matthias bernt-matthias commented Nov 22, 2021

--strip-suffix and --discard-cassava were forgotten in the command block.

read_modification and output_filtering were once the selects of conditionals which were removed in ttps://github.com/galaxyproject/tools-iuc/commit
/9a3d1b1c3c2e2d1f6d06fa92e9a95580e8529291

xref #4095
FOR CONTRIBUTOR:

  • - I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • - License permits unrestricted use (educational + commercial)
  • - This PR adds a new tool or tool collection
  • - This PR updates an existing tool or tool collection
  • - This PR does something else (explain below)

this was once the select of a conditional which was removed in
galaxyproject@9a3d1b1
@bernt-matthias bernt-matthias changed the title cutadapt: remove absent read_modification from tests cutadapt: add missing arguments and remove unsued test params Nov 22, 2021
@bernt-matthias bernt-matthias force-pushed the topic/cutadapt-readmod branch 2 times, most recently from 540beea to 7ccb4d4 Compare November 23, 2021 14:48
--strip-suffix seems absent from the beginning
--discard-cassava was apparently forgotten in galaxyproject#3704

xref galaxyproject#4095
@bgruening bgruening merged commit 9ec830a into galaxyproject:master Nov 27, 2021
@bernt-matthias bernt-matthias deleted the topic/cutadapt-readmod branch March 14, 2022 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants