-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Update cd-hit to 4.8.1, add cd-hit-454, cd-hit-dup, cd-hit-lap #3328
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good already.
I guess we should remove https://github.com/ASaiM/galaxytools/tree/master/tools/cdhit once this is merged?
</xml> | ||
<xml name="citations"> | ||
<citations> | ||
<citation type="doi">10.1093/bioinformatics/17.3.282</citation> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indentation seems off here... and throughout the file
@@ -0,0 +1,169 @@ | |||
<tool id="cd_hit_454" name="CD-HIT 454" version="@TOOL_VERSION@+galaxy@VERSION_SUFFIX@"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add a recent profile
edam_topics, edam_operations and xrefs would be nice to have as well
-gap $gap | ||
-gap-ext $gapext | ||
$out.bak | ||
-M \${GALAXY_MEMORY_MB:-0} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is 0 a useful default?
|
||
<token name="@LOG@"><![CDATA[ | ||
#if $out.log | ||
|& tee -a '$out_log' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need set -eo pipefail
What is the state here? Could you fix the conflicts? Once this is in we could also deprecate |
FOR CONTRIBUTOR:
Update: cd-hit, cd-hit-2d, cd-hit-est, cd-hit-est-2d to 4.8.1
Add: cd-hit-454, cd-hit-dup, cd-hit-lap
This current version of this wrapper (version 4.6.8.1) is not included on usegalaxy.eu, usegalaxy.org and usegalaxy.org.au. But there are multiple old wrappers available
https://github.com/galaxyproject/tools-devteam/tree/master/tools/cd_hit_dup
https://github.com/galaxyproject/tools-iuc/blob/master/tools/cdhit/cd_hit.xml
https://github.com/ASaiM/galaxytools/tree/master/tools/cdhit/
And there is an additional tool for cd-hit outputs: https://github.com/ASaiM/galaxytools/tree/master/tools/format_cd_hit_output/ . I am not sure if this is still required and didn't include it here.
There are recipes available for cd-hit and -cd-hit-auxtools. Both are based on the same project repository. Maybe it's a good idea to merge them?
Following subcommands are mentioned in the tool wiki, but skipped here: