Do not override None with empty string #950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partial solution to galaxyproject#946 (first attempt)
natefoo
approved these changes
Aug 8, 2019
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial solution to #946; it addresses the IOError.
The cause for the error is described here: #946 (comment)
The edits prevent planemo from passing an empty string as the value of
data_manager_config_fileto the managed galaxy instance as part of kwargs. An empty string was resolved to the current directory and, due to stricter exception handling in galaxy (introduced in galaxyproject/galaxy#921) that caused an error.This should work correctly for both cases, when a path exists (when it's a data manager) and when it doesn't ( when it's a regular tool or a directory).
Ping @jmchilton , @natefoo . (I am not at all sure this is the optimal solution here, but it's my best guess, for now.)