Skip to content

Commit

Permalink
Merge pull request #950 from ic4f/fix_dm_conf_file
Browse files Browse the repository at this point in the history
Do not override None with empty string
  • Loading branch information
jmchilton authored Aug 8, 2019
2 parents 1df1982 + 7633473 commit 0bdc101
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions planemo/galaxy/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,7 @@ def config_join(*args):
watch_tools="auto",
default_job_shell="/bin/bash", # For conda dependency resolution
tool_data_table_config_path=tool_data_table,
data_manager_config_file=",".join(data_manager_config_paths),
data_manager_config_file=",".join(data_manager_config_paths) or None, # without 'or None' may raise IOError in galaxy (see #946)
integrated_tool_panel_config=("${temp_directory}/"
"integrated_tool_panel_conf.xml"),
migrated_tools_config=empty_tool_conf,
Expand Down Expand Up @@ -1271,9 +1271,10 @@ def _ensure_galaxy_repository_available(ctx, kwds):
def _build_env_for_galaxy(properties, template_args):
env = {}
for key, value in iteritems(properties):
var = "GALAXY_CONFIG_OVERRIDE_%s" % key.upper()
value = _sub(value, template_args)
env[var] = value
if value is not None: # Do not override None with empty string
var = "GALAXY_CONFIG_OVERRIDE_%s" % key.upper()
value = _sub(value, template_args)
env[var] = value
return env


Expand Down

0 comments on commit 0bdc101

Please sign in to comment.