Update best_practice_search() for changes in galaxy-tool-util
#1224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
This comment was marked as resolved.
This comment was marked as resolved.
nsoranzo
added a commit
to nsoranzo/galaxy
that referenced
this pull request
Apr 4, 2022
Fix issue found when testing planemo in galaxyproject/planemo#1224 (comment) : ``` 2022-04-01T14:44:05.3964452Z [2022-04-01 14:41:23 +0000] [6904] [WARNING] Invalid HTTP request received. 2022-04-01T14:44:05.3964583Z Traceback (most recent call last): 2022-04-01T14:44:05.3965087Z File "/tmp/planemo-test-workspace/gx_venv_3/lib/python3.7/site-packages/uvicorn/protocols/http/h11_impl.py", line 136, in handle_events 2022-04-01T14:44:05.3965218Z event = self.conn.next_event() 2022-04-01T14:44:05.3965652Z File "/tmp/planemo-test-workspace/gx_venv_3/lib/python3.7/site-packages/h11/_connection.py", line 443, in next_event 2022-04-01T14:44:05.3965801Z exc._reraise_as_remote_protocol_error() 2022-04-01T14:44:05.3966277Z File "/tmp/planemo-test-workspace/gx_venv_3/lib/python3.7/site-packages/h11/_util.py", line 76, in _reraise_as_remote_protocol_error 2022-04-01T14:44:05.3966383Z raise self 2022-04-01T14:44:05.3966831Z File "/tmp/planemo-test-workspace/gx_venv_3/lib/python3.7/site-packages/h11/_connection.py", line 425, in next_event 2022-04-01T14:44:05.3966977Z event = self._extract_next_receive_event() 2022-04-01T14:44:05.3967445Z File "/tmp/planemo-test-workspace/gx_venv_3/lib/python3.7/site-packages/h11/_connection.py", line 367, in _extract_next_receive_event 2022-04-01T14:44:05.3967588Z event = self._reader(self._receive_buffer) 2022-04-01T14:44:05.3968049Z File "/tmp/planemo-test-workspace/gx_venv_3/lib/python3.7/site-packages/h11/_readers.py", line 73, in maybe_read_from_IDLE_client 2022-04-01T14:44:05.3968225Z request_line_re, lines[0], "illegal request line: {!r}", lines[0] 2022-04-01T14:44:05.3968629Z File "/tmp/planemo-test-workspace/gx_venv_3/lib/python3.7/site-packages/h11/_util.py", line 88, in validate 2022-04-01T14:44:05.3968781Z raise LocalProtocolError(msg) 2022-04-01T14:44:05.3969215Z h11._util.RemoteProtocolError: illegal request line: bytearray(b'--a250a2c0546542508998e4e0ac8f1001') 2022-04-01T14:44:05.3969497Z [2022-04-01 14:41:23 +0000] [6904] [WARNING] Invalid HTTP request received. 2022-04-01T14:44:05.3969623Z Traceback (most recent call last): 2022-04-01T14:44:05.3970105Z File "/tmp/planemo-test-workspace/gx_venv_3/lib/python3.7/site-packages/uvicorn/protocols/http/h11_impl.py", line 136, in handle_events 2022-04-01T14:44:05.3970231Z event = self.conn.next_event() 2022-04-01T14:44:05.3970655Z File "/tmp/planemo-test-workspace/gx_venv_3/lib/python3.7/site-packages/h11/_connection.py", line 423, in next_event 2022-04-01T14:44:05.3971003Z raise RemoteProtocolError("Can't receive data when peer state is ERROR") 2022-04-01T14:44:05.3971287Z h11._util.RemoteProtocolError: Can't receive data when peer state is ERROR ```
5 tasks
nsoranzo
added a commit
to nsoranzo/galaxy
that referenced
this pull request
Apr 4, 2022
Fix issue found when testing planemo in galaxyproject/planemo#1224 (comment) : ``` 2022-04-01T14:44:05.3964452Z [2022-04-01 14:41:23 +0000] [6904] [WARNING] Invalid HTTP request received. 2022-04-01T14:44:05.3964583Z Traceback (most recent call last): 2022-04-01T14:44:05.3965087Z File "/tmp/planemo-test-workspace/gx_venv_3/lib/python3.7/site-packages/uvicorn/protocols/http/h11_impl.py", line 136, in handle_events 2022-04-01T14:44:05.3965218Z event = self.conn.next_event() 2022-04-01T14:44:05.3965652Z File "/tmp/planemo-test-workspace/gx_venv_3/lib/python3.7/site-packages/h11/_connection.py", line 443, in next_event 2022-04-01T14:44:05.3965801Z exc._reraise_as_remote_protocol_error() 2022-04-01T14:44:05.3966277Z File "/tmp/planemo-test-workspace/gx_venv_3/lib/python3.7/site-packages/h11/_util.py", line 76, in _reraise_as_remote_protocol_error 2022-04-01T14:44:05.3966383Z raise self 2022-04-01T14:44:05.3966831Z File "/tmp/planemo-test-workspace/gx_venv_3/lib/python3.7/site-packages/h11/_connection.py", line 425, in next_event 2022-04-01T14:44:05.3966977Z event = self._extract_next_receive_event() 2022-04-01T14:44:05.3967445Z File "/tmp/planemo-test-workspace/gx_venv_3/lib/python3.7/site-packages/h11/_connection.py", line 367, in _extract_next_receive_event 2022-04-01T14:44:05.3967588Z event = self._reader(self._receive_buffer) 2022-04-01T14:44:05.3968049Z File "/tmp/planemo-test-workspace/gx_venv_3/lib/python3.7/site-packages/h11/_readers.py", line 73, in maybe_read_from_IDLE_client 2022-04-01T14:44:05.3968225Z request_line_re, lines[0], "illegal request line: {!r}", lines[0] 2022-04-01T14:44:05.3968629Z File "/tmp/planemo-test-workspace/gx_venv_3/lib/python3.7/site-packages/h11/_util.py", line 88, in validate 2022-04-01T14:44:05.3968781Z raise LocalProtocolError(msg) 2022-04-01T14:44:05.3969215Z h11._util.RemoteProtocolError: illegal request line: bytearray(b'--a250a2c0546542508998e4e0ac8f1001') 2022-04-01T14:44:05.3969497Z [2022-04-01 14:41:23 +0000] [6904] [WARNING] Invalid HTTP request received. 2022-04-01T14:44:05.3969623Z Traceback (most recent call last): 2022-04-01T14:44:05.3970105Z File "/tmp/planemo-test-workspace/gx_venv_3/lib/python3.7/site-packages/uvicorn/protocols/http/h11_impl.py", line 136, in handle_events 2022-04-01T14:44:05.3970231Z event = self.conn.next_event() 2022-04-01T14:44:05.3970655Z File "/tmp/planemo-test-workspace/gx_venv_3/lib/python3.7/site-packages/h11/_connection.py", line 423, in next_event 2022-04-01T14:44:05.3971003Z raise RemoteProtocolError("Can't receive data when peer state is ERROR") 2022-04-01T14:44:05.3971287Z h11._util.RemoteProtocolError: Can't receive data when peer state is ERROR ```
|
The unit-quick and unit-nonredundant-noclientbuild-noshed test builds now pass, but they don't complete properly until they time out after 90'. Maybe a Galaxy process that doesn't stop? |
nsoranzo
force-pushed
the
update_best_practice_search
branch
2 times, most recently
from
c70605a to
fb72273
Compare
In galaxyproject/galaxy#13532 I've removed the `channels_override` parameter from the `best_search_result()` method in galaxy-tool-util.
nsoranzo
force-pushed
the
update_best_practice_search
branch
from
fb72273 to
9dec705
Compare
nsoranzo
force-pushed
the
update_best_practice_search
branch
2 times, most recently
from
13222ff to
e56c608
Compare
|
Found the issue with tests not terminating! |
nsoranzo
force-pushed
the
update_best_practice_search
branch
from
e56c608 to
2fde60d
Compare
nsoranzo
force-pushed
the
update_best_practice_search
branch
from
2fde60d to
1a13d8c
Compare
- Remove unused `skip_unless_python_2_7()` function. - Do not use mutable data structures for argument defaults. - Sync ``modify_environ()`` with Galaxy version, with fixes.
nsoranzo
force-pushed
the
update_best_practice_search
branch
from
1a13d8c to
76553a2
Compare
|
Thank you so much @nsoranzo ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In galaxyproject/galaxy#13532 I've removed the
channels_overrideparameter from thebest_search_result()method in galaxy-tool-util.