-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'metaQuantome function' workflow #628
base: main
Are you sure you want to change the base?
Add 'metaQuantome function' workflow #628
Conversation
Test Results (powered by Planemo)Test Summary
Errored Tests
Passed Tests
|
asserts: | ||
has_text: | ||
text: "GO:0000015" | ||
Bar plot data for sample T2: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's sample T2 / T4 / T7 ?
More input/output and analysis description is required in the README and as part of input annotations for me to review this properly. |
@@ -0,0 +1,4 @@ | |||
# metaQuantome 2: Function |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a strange title. Sure there is a tutorial with that name, but this is not the gtn repo and it won't make any sense without that context.
@@ -0,0 +1,4 @@ | |||
# metaQuantome 2: Function | |||
metaQuantome software suite Easterly et al. 2019 was developed by the Team for quantitative and statistical analysis of metaproteomics data. For taxonomic and functional expression analysis within the microbial community, metaQuantome leverages peptide-level quantitative information to generate visual outputs for data interpretation. It also generates outputs that help in understanding the taxonomic contribution to a selected function as well as functions expressed by selected taxonomic group. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This paragraph doesn't explain what the WF is doing or how that's related to the software suite.
workflows/proteomics/metaquantome-function/metaquantome_function_wf.ga
Outdated
Show resolved
Hide resolved
"owner": "galaxyp", | ||
"tool_shed": "toolshed.g2.bx.psu.edu" | ||
}, | ||
"tool_state": "{\"samps_args\": {\"samps_src\": \"build\", \"__current_case__\": 0, \"samps\": [{\"__index__\": 0, \"group_name\": \"T2\", \"col_names\": \"T2_A1,T2_B1\"}, {\"__index__\": 1, \"group_name\": \"T4\", \"col_names\": \"T4A_1,T4B_1\"}, {\"__index__\": 2, \"group_name\": \"T7\", \"col_names\": \"T7A_1,T7B_1\"}]}, \"__page__\": null, \"__rerun_remap_job_id__\": null}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This step is strange. Why tie a general WF to specific sample and group names? All of these should probably be WF input params.
] | ||
}, | ||
"2": { | ||
"annotation": "Functional metaQuantome file", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no idea what kind of input this is.
"workflow_outputs": [] | ||
}, | ||
"3": { | ||
"annotation": "Intensity metaQuantome file", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, no idea
…on_wf.ga Co-authored-by: Wolfgang Maier <[email protected]>
WF steps outlined
We followed the recommendation to publish the workflow (licence, author list and email, steps annotations...)
planemo workflow_test_init
to use a valid invocationplanemo test
command on the usegalaxy.eu serverThanks 😃