Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new workflow to polish assembly #200

Merged
merged 9 commits into from
Sep 7, 2023

Conversation

AnnaSyme
Copy link
Contributor

Added to folder "genome-assembly", in subfolder "polish-with-long-reads"

@AnnaSyme
Copy link
Contributor Author

ping @mvdbeek this is ready to go if you wouldn't mind having a look?

@mvdbeek
Copy link
Member

mvdbeek commented Aug 16, 2023

Looks great, my only suggestion is to restrict the minimap profile parameter values that the user can select (or provide a list of options, if some of them don't make sense)
Screenshot 2023-08-16 at 10 14 37

@AnnaSyme
Copy link
Contributor Author

thanks @mvdbeek this is a good idea. I want to provide a default value but also a list of suggested values. However is this possible? When I do put in the default, but also the suggested values, I can't see them in the drop-down list when I go to run the workflow. If I have no default value, I can see all the suggested values. Is there a way around this?

@mvdbeek
Copy link
Member

mvdbeek commented Aug 23, 2023

Kind of, the default value only works for optional parameters, so what would work (but is a little clunky) is when you define the possible parameters, you can put the default first.
Screenshot 2023-08-23 at 10 41 21

@AnnaSyme
Copy link
Contributor Author

thanks have done this for these suggested values @mvdbeek

@mvdbeek
Copy link
Member

mvdbeek commented Aug 28, 2023

Do you need to move Galaxy-Workflow-Assembly_polishing_with_long_reads.ga to Assembly_polishing_with_long_reads.ga ? There are now two workflows in here, and only one has a test.

…shing-with-long-reads.ga

Has now been replaced with updated workflow.
…bly_polishing_with_long_reads.ga

Corrected name
@AnnaSyme
Copy link
Contributor Author

AnnaSyme commented Sep 5, 2023

Thanks @mvdbeek - I've removed the older workflow and re-named the newer one - does that look ok?

…th-long-reads.ga

re-name with dashes not underscores
Copy link
Member

@mvdbeek mvdbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very cool, I'll merge when the tests are passing!

@mvdbeek mvdbeek merged commit ffdc8a0 into galaxyproject:main Sep 7, 2023
5 checks passed
@bgruening
Copy link
Member

🎉 🎉 🎉 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants