Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.2] Cleanup vega descriptions for workflow metrics. #19268

Open
wants to merge 1 commit into
base: release_24.2
Choose a base branch
from
Open

[24.2] Cleanup vega descriptions for workflow metrics. #19268

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 19 additions & 5 deletions client/src/components/WorkflowInvocationState/WorkflowInvocationMetrics.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,12 +55,14 @@ interface boxplotData {
x_title: string;
y_title: string;
values?: { x: string; y: Number }[];
description: string;
}

function metricToSpecData(
jobMetrics: components["schemas"]["WorkflowJobMetric"][] | undefined,
metricName: string,
yTitle: string,
description: string,
transform?: (param: number) => number
) {
const wallclock = jobMetrics?.filter((jobMetric) => jobMetric.name == metricName);
Expand All @@ -78,29 +80,41 @@ function metricToSpecData(
x_title: attributeToLabel[groupBy.value],
y_title: yTitle,
values,
description,
};
}

const wallclock: ComputedRef<boxplotData> = computed(() => {
return metricToSpecData(jobMetrics.value, "runtime_seconds", "Runtime (in Seconds)");
return metricToSpecData(jobMetrics.value, "runtime_seconds", "Runtime (in Seconds)", "Boxplot of runtime");
});

const coresAllocated: ComputedRef<boxplotData> = computed(() => {
return metricToSpecData(jobMetrics.value, "galaxy_slots", "Cores Allocated");
return metricToSpecData(jobMetrics.value, "galaxy_slots", "Cores Allocated", "Boxplot of cores allocated");
});

const memoryAllocated: ComputedRef<boxplotData> = computed(() => {
return metricToSpecData(jobMetrics.value, "galaxy_memory_mb", "Memory Allocated (in MB)");
return metricToSpecData(
jobMetrics.value,
"galaxy_memory_mb",
"Memory Allocated (in MB)",
"Boxplot of memory allocated"
);
});

const peakMemory: ComputedRef<boxplotData> = computed(() => {
return metricToSpecData(jobMetrics.value, "memory.peak", "Max memory usage recorded (in MB)", (v) => v / 1024 ** 2);
return metricToSpecData(
jobMetrics.value,
"memory.peak",
"Max memory usage recorded (in MB)",
"Boxplot of peak memory consumed",
(v) => v / 1024 ** 2
);
});

function itemToSpec(item: boxplotData) {
const spec: VisualizationSpec = {
$schema: "https://vega.github.io/schema/vega-lite/v5.json",
description: "A boxplot with jittered points.",
description: item.description,
data: {
values: item.values!,
},
Expand Down
Loading