Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.2] Cleanup vega descriptions for workflow metrics. #19268

Open
wants to merge 1 commit into
base: release_24.2
Choose a base branch
from

Conversation

jmchilton
Copy link
Member

It isn't exposed explicitly but seeing this text when opening the Vega source or using the Vega editor from the link on the widget was a little off-putting. I thought maybe the data was random at first but the jitter is only added in the x direction for reasons that make sense once you think about but isn't something I think should be forefronted.

How to test the changes?

  • Instructions for manual testing are as follows:
    1. View the metrics in the Vega editor.

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

It isn't exposed explictly but seeing this text when opening the Vega source or using the Vega editor from the link on the widget was a little offputting. I thought maybe the data was random at first but the jitter is only added in the x direction for reasons that make sense once you think about but isn't something I think should be forefronted.
@jmchilton jmchilton added kind/bug kind/enhancement area/UI-UX area/workflows release-testing-24.2 Issues stemming from 24.2 release testing process and PRs to address them labels Dec 5, 2024
@jmchilton jmchilton requested a review from mvdbeek December 5, 2024 21:23
@jmchilton jmchilton marked this pull request as ready for review December 5, 2024 22:29
@github-actions github-actions bot added this to the 25.0 milestone Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/UI-UX area/workflows kind/bug kind/enhancement release-testing-24.2 Issues stemming from 24.2 release testing process and PRs to address them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant