Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tiff viewer to use script entry_point #19151

Merged
merged 6 commits into from
Nov 16, 2024

Conversation

guerler
Copy link
Contributor

@guerler guerler commented Nov 16, 2024

Similar to #19150, but applied to the Tiff viewer. This PR removes the overhead of having to embed the Tiff viewer into Galaxy's client bundle by using the recently revised script entry_point. See: #18651.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@guerler guerler added kind/enhancement kind/refactoring cleanup or refactoring of existing code, no functional changes area/visualizations labels Nov 16, 2024
@guerler guerler added this to the 24.2 milestone Nov 16, 2024
@guerler guerler marked this pull request as ready for review November 16, 2024 12:43
@guerler guerler merged commit 65d807c into galaxyproject:dev Nov 16, 2024
54 checks passed
@guerler guerler deleted the update_tiff_viewer branch November 16, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/visualizations kind/enhancement kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants