Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch update annotate image to new script entry_point #19150

Merged
merged 4 commits into from
Nov 16, 2024

Conversation

guerler
Copy link
Contributor

@guerler guerler commented Nov 16, 2024

PR switches the update annotate image viewer from deprecated backbone-based client bundle to updated script entry point. Instead of requiring the Galaxy client bundle, the visualization now just collects the required dataset id from the DOM container attribute.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@guerler guerler added kind/enhancement area/UI-UX kind/refactoring cleanup or refactoring of existing code, no functional changes labels Nov 16, 2024
@guerler guerler added this to the 24.2 milestone Nov 16, 2024
@guerler guerler marked this pull request as ready for review November 16, 2024 11:34
@guerler guerler merged commit 747bced into galaxyproject:dev Nov 16, 2024
51 checks passed
@guerler guerler deleted the update_annotate_image branch November 16, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/UI-UX kind/enhancement kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants