-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix commas that shouldn't be in biotools_mappings.tsv #18919
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess these are coming from an upstream source https://github.com/bio-tools/content if i can believe galaxy.yml.sample ? That repo doesn't exist anymore though, so ... ?
@mvdbeek https://archive.softwareheritage.org/browse/origin/directory/?origin_url=https://github.com/bio-tools/content at least they warned us 😆
@jmchilton you might also be missing the ones with spaces? e.g. L263 rxlr_motifs. And in that case i would argue both biotools xrefs are relevant. do we need to pick one? is there a way to have both annotations? |
Its redirecting to https://github.com/research-software-ecosystem/content ... is the redirect not working for you? |
https://github.com/galaxyproject/galaxy/pull/18919/files#diff-fd14abe36b9effe9869962313d1b668af331e9cd4234faa4a08bab8115eed210L135 last one, I think ( |
It looks like it already had an entry - so I think we're fine to just delete it. |
Thanks @jmchilton |
Fixes #18903
How to test the changes?
(Select all options that apply)
License