Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add message to Invocations panel for no invocations #18180

Merged
merged 1 commit into from
May 20, 2024

Conversation

ahmedhamidawan
Copy link
Member

This adds a message for no invocations to display:
image

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@ahmedhamidawan
Copy link
Member Author

ahmedhamidawan commented May 20, 2024

Move the Go-to-all button at the top of ActivityPanel? (Not in this PR):

... Could we get the full invocation list button at the top of the panel ...

Originally posted by @mvdbeek in #18137 (comment)
Can also include this here if needed? (not included in this PR):

Before After
go_to_btn_before go_to_btn_after

Copy link
Member

@jdavcs jdavcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@jdavcs jdavcs merged commit f3cb81d into galaxyproject:dev May 20, 2024
32 checks passed
@ahmedhamidawan ahmedhamidawan changed the title Improve Invocations panel Add message to Invocations panel for no invocations May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants