Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.1] Move activity panel go to button to top #18182

Merged

Conversation

ahmedhamidawan
Copy link
Member

As discussed in #18180 (comment)

Before After
go_to_btn_before go_to_btn_after

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@ahmedhamidawan ahmedhamidawan marked this pull request as ready for review May 20, 2024 20:24
@ahmedhamidawan
Copy link
Member Author

ahmedhamidawan commented May 20, 2024

This failing selenium should be unrelated to these changes:

FAILED lib/galaxy_test/selenium/test_personal_information.py::TestManageInformation::test_public_name

@jdavcs
Copy link
Member

jdavcs commented May 21, 2024

@ahmedhamidawan please target the new release_24.1 branch, I'll then merge this.

@ahmedhamidawan ahmedhamidawan changed the base branch from dev to release_24.1 May 21, 2024 03:08
@ahmedhamidawan ahmedhamidawan changed the title Move activity panel go to button to top [24.1] Move activity panel go to button to top May 21, 2024
@ahmedhamidawan
Copy link
Member Author

Thank you @jdavcs !

@mvdbeek mvdbeek merged commit 5a90457 into galaxyproject:release_24.1 May 21, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants