Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.0] Show dataset image in workflow_outputs display listing. #17964

Merged
merged 4 commits into from
Apr 11, 2024

Conversation

dannon
Copy link
Member

@dannon dannon commented Apr 11, 2024

Fixes #16558

Another approach might be to overhaul the workflow outputs directive logic to divert between the two directives (history_dataset_as_image, history_dataset_display), but it seems nicer to me to just do the right thing for image datatypes in history_dataset_display.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@dannon dannon marked this pull request as ready for review April 11, 2024 11:58
@github-actions github-actions bot added this to the 24.1 milestone Apr 11, 2024
@dannon dannon changed the title [24.0] Show dataset image in history dataset display [24.0] Show dataset image in workflow_outputs display listing. Apr 11, 2024
@martenson martenson merged commit f6a4526 into galaxyproject:release_24.0 Apr 11, 2024
30 checks passed
@martenson
Copy link
Member

thanks @dannon !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants