Migrate dataset store to Pinia
#16709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davelopez
added
area/UI-UX
kind/refactoring
`storeCountGetter` is no longer used
Includes migration to script setup Composition API + TS
This is to make it work with Vue2 in Vue3 we can get rid of this.
davelopez
force-pushed
the
migrate_dataset_store_pinia
branch
from
56794bb to
f80cf2c
Compare
Co-authored-by: Laila Los <[email protected]>
dannon
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to the store migration to Pinia:
DatasetDetailscomponent to script setup composition API + TypescriptHow to test the changes?
License