Use Vue.set/delete to update loading status

This is to make it work with Vue2 in Vue3 we can get rid of this.
galaxyproject · Sep 20, 2023 · f80cf2c · f80cf2c
1 parent e7fe050
commit f80cf2c
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/client/src/stores/datasetStore.ts b/client/src/stores/datasetStore.ts
@@ -25,11 +25,14 @@ export const useDatasetStore = defineStore("datasetStore", () => {
     });
 
     async function fetchDataset(params: { id: string }) {
-        loadingDatasets.value[params.id] = true;
-        const dataset = await fetchDatasetDetails(params);
-        Vue.set(storedDatasets.value, dataset.id, dataset);
-        delete loadingDatasets.value[params.id];
-        return dataset;
+        Vue.set(loadingDatasets.value, params.id, true);
+        try {
+            const dataset = await fetchDatasetDetails(params);
+            Vue.set(storedDatasets.value, dataset.id, dataset);
+            return dataset;
+        } finally {
+            Vue.delete(loadingDatasets.value, params.id);
+        }
     }
 
     function saveDatasets(historyContentsPayload: HistoryContentItemBase[]) {