Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #10369
Very much WIP. First steps towards moving us to alembic. The new tests in the PR pass, the rest breaks, for now.
The alembic stuff is in
model/migrations
. There's arun
function that handles the basic logic + aDBManager
class that takes care of all db/alembic interactions. The steps are as follows:My idea is to provide an automated upgrade path for db versions that already have SQLAlchemy Migrate, but not prior to that (I assume there's no reason to go that far back). This will be simpler than the current logic. I think we can phase out this path in 1-2 releases - that way we'll gradually remove SQLAlchemy Migrate from the code base.
The current implementation is far from complete. Also, I did not include views and triggers intentionally - I think it will make more sense to let alembic handle them (as a revision). Or maybe not.