Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move from sqlalchemy-migrate to alembic #10369

Closed
jdavcs opened this issue Oct 7, 2020 · 2 comments
Closed

Move from sqlalchemy-migrate to alembic #10369

jdavcs opened this issue Oct 7, 2020 · 2 comments
Assignees
@jdavcs
Labels
area/backend area/database Galaxy's database or data access layer kind/enhancement
Milestone
22.05

Comments

@jdavcs
Copy link
Member

jdavcs commented Oct 7, 2020 •
edited
Loading

It's time we move from sqlalchemy-migrate to alembic.
See discussion here: #7159 (comment) + comments here and here. There are 12 occurrences of # SQLAlchemy Migrate has a bug in migration scripts (11 refer to the same bug). As mentioned in the linked discussion, and to the best of my knowledge, it appears that sqlalchemy-migrate is no longer maintained (last commit was a year ago; moved to opendev), whereas alembic is doing fine (current version 1.4.3). I think we should move.

Unless there are objections, I'd like to take this on, aiming for the 21.01 21.05 release.
@jdavcs jdavcs added kind/enhancement area/database Galaxy's database or data access layer labels Oct 7, 2020
@jdavcs jdavcs added this to the 21.01 milestone Oct 7, 2020
@jdavcs jdavcs self-assigned this Oct 7, 2020
@jdavcs jdavcs mentioned this issue Jan 6, 2021
Closed
@mvdbeek mvdbeek mentioned this issue Jan 6, 2021
Closed
23 tasks
@jmchilton jmchilton modified the milestones: 21.01, 21.05 Mar 4, 2021
@jmchilton jmchilton mentioned this issue Apr 12, 2021
Closed
12 tasks
@mvdbeek mvdbeek modified the milestones: 21.05, 21.09 May 6, 2021
@jmchilton jmchilton mentioned this issue Sep 1, 2021
Closed
24 tasks
@mvdbeek mvdbeek modified the milestones: 21.09, 22.01 Sep 28, 2021
@jdavcs jdavcs mentioned this issue Oct 8, 2021
Merged
4 tasks
This was referenced Oct 15, 2021
Open
Merged
@jdavcs jdavcs mentioned this issue Nov 8, 2021
Closed
27 tasks
@jdavcs jdavcs mentioned this issue Dec 31, 2021
Closed
5 tasks
@jdavcs jdavcs modified the milestones: 22.01, 22.05 Jan 31, 2022
@jdavcs
Copy link
Member Author

jdavcs commented Jan 31, 2022

Changing milestone as per #13108 (comment)

@jdavcs
Copy link
Member Author

jdavcs commented Mar 11, 2022

Done in #13513.

@jdavcs jdavcs closed this as completed Mar 11, 2022
@jdavcs jdavcs removed the status/WIP label Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdavcs jdavcs

Labels
area/backend area/database Galaxy's database or data access layer kind/enhancement
Projects
None yet
Milestone
22.05
Development

No branches or pull requests
3 participants
@jmchilton @jdavcs @mvdbeek