feat: add sell_all for route executor #888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Crate versions that have been updated:
Runtime version has not been increased. |
mrq1911
approved these changes
Aug 9, 2024
…l-all # Conflicts: # pallets/route-executor/src/lib.rs
jak-pan
approved these changes
Aug 26, 2024
@jak-pan Although it is true that the fee payment asset is indeed HDX in the native balance test, it does not have any impact as in integration tests the tx fees are not deducted directly. Anyway, I tested out sell_all on chopsticks, and working fine, first the fee is deducated then the rest is sold in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #883