New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sell all functions to router and AMMs #883

Closed

jak-pan opened this issue Jul 29, 2024 · 1 comment · Fixed by #888

Assignees

Contributor

jak-pan commented Jul 29, 2024

Similar to https://github.com/open-web3-stack/open-runtime-module-library/blob/23c8363d53fe8580f636a7f820c54b994d1b96f7/tokens/src/lib.rs#L522 this would allow us to create simpler UX and pass through functionality with XCM programs allowing better composability in similar sense that buy_for works for fee payment.

dmoka self-assigned this

Contributor

dmoka commented Aug 7, 2024 •

edited

Loading

For now we do only a sell_all for router which solves the Max button issue.

dmoka mentioned this issue

feat: add sell_all for route executor #888

Merged

1 task

dmoka closed this as completed in #888

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment