Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set ODS from ids objects #282

Closed
wants to merge 69 commits into from
Closed

Set ODS from ids objects #282

wants to merge 69 commits into from

Conversation

AreWeDreaming
Copy link
Collaborator

Leaf of #258.
Allows an ODS to be set using an IDS (not database) object.
Example syntax

ods = load_omas_imas(paths=omas_paths,
                                     imas_version=os.environ["IMAS_VERSION"], 
                                     ext_ids=ids)

with omas_paths a list of IMAS paths in the form of equilibrium.time_slice.0.profiles_2d.0.psi and ids in this case an instance of imas.equilibrium() with data.
Limitations:

  • Does not allow automatic discovery, i.e. only works if paths is set
  • Does not allow broadcasting, e.g. equilibrium.time_slice.:.profiles_2d

@AreWeDreaming
Extended magnetic mapping
f0e5394 
- This my crude attempt to allow mapping between
rho_pol_norm <-> rho_tor_norm
- This also includes phi
- I qualitatively tested rho_pol_norm -> rho_tor_norm
- Might have some COCOS issues
- Probably overly complicated
- Needs dynamic fetching of `phi` and `rho_pol_norm`
@AreWeDreaming
Fixed some horrible math errors from last commit
2f0e0b3 
- Tested against mapping form OMFITprofiles
- Results are OK by eye. Numerical verification still pending.
@AreWeDreaming
Fixed error in rho_tor to rho_pol conversion
a634444
@AreWeDreaming
Merged master into this branch
1d7ab5e
@AreWeDreaming
Fixed some bugs, but the result is still wrong
a35e79d
@AreWeDreaming
Fixed broken psi <-> conversion
df2cf6b 
- Results seem good now
@AreWeDreaming
Merge remote-tracking branch 'origin/master' into mapping_to_from_rho…
989b295 
…_tor_norm
@AreWeDreaming
Some changes that allow imas_set for ids objects
fbdd940
@AreWeDreaming
Merge branch 'EFIT_mdsplus_mapping' into test_new_EFIT_mappings_for_IDA
37fb8f0
@AreWeDreaming
Merge remote-tracking branch 'origin/EFIT_mdsplus_mapping' into test_…
ed3700f 
…new_EFIT_mappings_for_IDA
@AreWeDreaming
Merge remote-tracking branch 'origin/imas_set_for_ids_objects' into t…
bae815f 
…est_new_EFIT_mappings_for_IDA
@AreWeDreaming
Merge remote-tracking branch 'origin/EFIT_mdsplus_mapping' into test_…
d0a7197 
…new_EFIT_mappings_for_IDA
@AreWeDreaming
Merge remote-tracking branch 'origin/EFIT_mdsplus_mapping' into test_…
432a26b 
…new_EFIT_mappings_for_IDA
@AreWeDreaming
Merge remote-tracking branch 'origin/EFIT_mdsplus_mapping' into test_…
97d4aba 
…new_EFIT_mappings_for_IDA
@AreWeDreaming
Merge remote-tracking branch 'origin/EFIT_mdsplus_mapping' into test_…
537f900 
…new_EFIT_mappings_for_IDA
@AreWeDreaming
Merge remote-tracking branch 'origin/EFIT_mdsplus_mapping' into test_…
a71f710 
…new_EFIT_mappings_for_IDA
@AreWeDreaming
Merge remote-tracking branch 'origin/EFIT_mdsplus_mapping' into test_…
8bf84e6 
…new_EFIT_mappings_for_IDA
@AreWeDreaming
Merge remote-tracking branch 'origin/EFIT_mdsplus_mapping' into test_…
b1df43a 
…new_EFIT_mappings_for_IDA
@AreWeDreaming
Merge remote-tracking branch 'origin/EFIT_mdsplus_mapping' into test_…
a8c90d9 
…new_EFIT_mappings_for_IDA
@AreWeDreaming
Merge remote-tracking branch 'origin/EFIT_mdsplus_mapping' into test_…
699ec70 
…new_EFIT_mappings_for_IDA
@AreWeDreaming
Merge remote-tracking branch 'origin/EFIT_mdsplus_mapping' into test_…
1382e78 
…new_EFIT_mappings_for_IDA
@AreWeDreaming
Merge remote-tracking branch 'origin/EFIT_mdsplus_mapping' into test_…
48371b6 
…new_EFIT_mappings_for_IDA
@AreWeDreaming
Merge remote-tracking branch 'origin/EFIT_mdsplus_mapping' into test_…
8d958d7 
…new_EFIT_mappings_for_IDA
@AreWeDreaming
Cherry picked changes from omas_viewer_dev
d7ad23e
@AreWeDreaming
Fixed missing raised exception
8bb1966
@AreWeDreaming
Merge branch 'EFIT_mdsplus_mapping' into cherry_pick_omas_viewer_dev
9a93cb5
@AreWeDreaming
How to fix closest_wall_point.distance
ed4dc2b
@AreWeDreaming
Fixed extra argument in min)4
97df88f
@AreWeDreaming
Merge remote-tracking branch 'origin/cherry_pick_omas_viewer_dev' int…
be1243f 
…o test_new_EFIT_mappings_for_IDA
@AreWeDreaming
Fixed missing raised exception
6b0bf16
@AreWeDreaming
Merge branch 'test_new_EFIT_mappings_for_IDA' of github.com:gafusion/…
2470512 
…omas into test_new_EFIT_mappings_for_IDA
@AreWeDreaming
Merge indentation fixes
d363957
@AreWeDreaming
Merge branch 'test_new_EFIT_mappings_for_IDA' of github.com:gafusion/…
e12d609 
…omas into test_new_EFIT_mappings_for_IDA
@AreWeDreaming
Merge branch 'EFIT_mdsplus_mapping' into test_new_EFIT_mappings_for_IDA
dc92fa9
@AreWeDreaming
Merge branch 'EFIT_mdsplus_mapping' into cherry_pick_omas_viewer_dev
a7fcf51
@AreWeDreaming
Fixes for the failing omas_plot regression test
4a3b09e
@AreWeDreaming
More robustly handle multiple run ids
db70f71
@AreWeDreaming
Added density_thermal, begrudgingly
96a5170
@AreWeDreaming
Handling mismatched times from profiles and eq
5576428
@AreWeDreaming
Merge remote-tracking branch 'origin/EFIT_mdsplus_mapping' into omas_…
a0cf687 
…plot_w_new_EFIT_mapping
@AreWeDreaming
use_subplot support without manager
0b3ed22
@AreWeDreaming
Merge branch 'master' into test_new_EFIT_mappings_for_IDA
a613a21
@AreWeDreaming
Merge branch 'test_new_EFIT_mappings_for_IDA' into omas_plot_w_new_EF…
2b0ff47 
…IT_mapping
@AreWeDreaming
Fixed error in carbon density and redundant loads
3c19d7b
@AreWeDreaming
Merge remote-tracking branch 'origin/master' into cherry_pick_omas_vi…
cd09d0d 
…ewer_dev
@AreWeDreaming
Attempt to fix regression
51dba47
@AreWeDreaming
Merge remote-tracking branch 'origin/master' into omas_plot_w_new_EFI…
8c0f4d7 
…T_mapping
@AreWeDreaming
Merge branch 'master' into cherry_pick_omas_viewer_dev
e0351d1
@AreWeDreaming
electrons.density_~~thermal~~
bef0a6e
@AreWeDreaming
Fixed density_thermal in sample data
b627204
@AreWeDreaming
Robustness upgrades to pass omas_test_plot
77bad43
@AreWeDreaming
Replace deprecated interp2d->RectBivariateSpline
ddaf49d 
- Plus 2 missed density_thermal
@AreWeDreaming
Merge branch 'cherry_pick_omas_viewer_dev' into omas_plot_w_new_EFIT_…
df0ae53 
…mapping
@AreWeDreaming AreWeDreaming changed the title Imas set for ids objects Set ODS from ids objects Dec 12, 2023
@github-actions GitHub Actions
Copy link

Stale pull request message

@github-actions github-actions bot closed this Feb 19, 2024
@AreWeDreaming AreWeDreaming deleted the imas_set_for_ids_objects branch January 6, 2025 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Blocked by other PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@AreWeDreaming