Omas plot w new efit mapping #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Still missing j_tor from EFITEXT tree
…plot_w_new_EFIT_mapping
|
Stale pull request message |
|
This really should be merged. It has some pretty sizeable changes. Notably #255 needs to be merged first. |
|
Oh #255 already was merged so that is good. |
This was referenced Dec 12, 2023
|
Stale pull request message |
|
Stale pull request message |
|
This allows picking a source for |
|
This PR has not seen any activity in the past 60 days. It is now marked as stale and will be closed in 7 days if no further activity is registered. |
torrinba
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
This all looks fine to me. And passes the OMAS and OMFIT regression tests.
Once you fix the conflicts I think we should merge @AreWeDreaming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependent on #256. This PR uses the new fields from #255 for the equilibrium summary plot. Regression test for
omas_plotpasses locally.