Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding selection option to Label #5536

Open
wants to merge 21 commits into
base: develop
Choose a base branch
from
Open

Adding selection option to Label #5536

Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
ae1cfc7
Add a flag to make label selectable
andydotxyz Feb 15, 2025
b959399
Copy/move entry selection handling to new selection.go
andydotxyz Feb 16, 2025
937416e
Show a menu to copy text out of selectable label
andydotxyz Feb 16, 2025
40f9284
Fix label tests
andydotxyz Feb 16, 2025
96622d3
Entry updates for test fixes
andydotxyz Feb 21, 2025
838fb06
Tests pass but need to fix refresh on Selectable change
andydotxyz Feb 21, 2025
87f75ae
Correct usage of API in test
andydotxyz Feb 21, 2025
8b646ed
Fix for mobile usage too
andydotxyz Feb 22, 2025
5d36e33
Add label selection test
andydotxyz Feb 23, 2025
ed12776
Adding copy shortcut
andydotxyz Feb 24, 2025
6aaf68d
Adding the correct toggling of selectable in label
andydotxyz Feb 24, 2025
44973da
Double and triple tap for label selection
andydotxyz Feb 24, 2025
199ff63
Fix lint suggestion
andydotxyz Feb 24, 2025
41c20d6
Remove lines for code review
andydotxyz Feb 25, 2025
f0db555
Update nil check and early return
andydotxyz Feb 26, 2025
b7e700c
Hide selections when we are not focussed.
andydotxyz Feb 26, 2025
026c503
Complete selectable work to be fully mobile compatible
andydotxyz Feb 26, 2025
c54bc2e
Tidy up remaining TODO
andydotxyz Feb 26, 2025
fd590b2
Critical line missed the commit...
andydotxyz Feb 26, 2025
dabdf5a
Remove debug
andydotxyz Feb 27, 2025
cab213e
Remove dead import
andydotxyz Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions test/app.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ type app struct {
propertyLock sync.RWMutex
storage fyne.Storage
lifecycle intapp.Lifecycle
clip fyne.Clipboard
cloud fyne.CloudProvider

// user action variables
Expand Down Expand Up @@ -64,7 +65,7 @@ func (a *app) Quit() {
}

func (a *app) Clipboard() fyne.Clipboard {
return NewClipboard()
return a.clip
}

func (a *app) UniqueID() string {
Expand Down Expand Up @@ -166,7 +167,7 @@ func NewApp() fyne.App {
settings := &testSettings{scale: 1.0, theme: Theme()}
prefs := internal.NewInMemoryPreferences()
store := &testStorage{}
test := &app{settings: settings, prefs: prefs, storage: store, driver: NewDriver().(*driver)}
test := &app{settings: settings, prefs: prefs, storage: store, driver: NewDriver().(*driver), clip: NewClipboard()}
settings.app = test
root, _ := store.docRootURI()
store.Docs = &internal.Docs{RootDocURI: root}
Expand Down
Loading
Loading