Adding selection option to Label #5536
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When set we add the hoverable panel to handle selection
And use that to enable selection on Label
andydotxyz
force-pushed
the
feature/selectablelabel
branch
2 times, most recently
from
bebc4e6 to
f24aedc
Compare
andydotxyz
force-pushed
the
feature/selectablelabel
branch
from
f24aedc to
40f9284
Compare
Jacalz
requested changes
Feb 24, 2025
Jacalz
reviewed
Feb 25, 2025
dweymouth
requested changes
Feb 26, 2025
Thanks, all fixed plus I found some issues with mobile details as well, working well now I think. |
|
Gah, missed the change in one file. Could have force pushed but forgot. Ah well, should be green now. |
Jacalz
previously approved these changes
Feb 26, 2025
sdassow
reviewed
Feb 27, 2025
widget/entry.go
Outdated
| @@ -288,6 +273,8 @@ func (e *Entry) FocusGained() { | |||
| e.setFieldsAndRefresh(func() { | |||
| e.dirty = true | |||
| e.focused = true | |||
|
|
|||
| log.Println("FOCUS") | |||
There was a problem hiding this comment.
How embarrassing! Fixed
There was a problem hiding this comment.
The import was accidentally left in leading to a compile error unfortunately
There was a problem hiding this comment.
Apologies, I should stop doing code commits on the bus!
There was a problem hiding this comment.
Different kind of bus factor, and we're all in for the ride 😉
Jacalz
approved these changes
Feb 27, 2025
dweymouth
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Selectable label incoming.
Got some tests to write/fix and a little refactoring to do - but I am pretty sure it's working well and has the right public API.
Checklist: