Skip to content
This repository has been archived by the owner on May 17, 2019. It is now read-only.

Ensure test --watch continues watching after test failure #64

Merged
merged 1 commit into from
Dec 8, 2017
Merged

Ensure test --watch continues watching after test failure #64

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion commands/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,9 @@ exports.run = async function({dir = '.', cover, watch, skipBuild}) {
await runTests();

if (watch) {
compiler.on('done', runTests);
compiler.on('done', () => {
runTests().catch(() => {}); // ignore error, since test output is already actionable enough
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we log something here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think logging would make the test output unnecessarily noisy. The stack trace is already part of the test report

});
}

return {
Expand Down