This repository has been archived by the owner on May 17, 2019. It is now read-only.
Ensure test --watch continues watching after test failure
#64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidkearns
approved these changes
Dec 8, 2017
| @@ -64,7 +64,9 @@ exports.run = async function({dir = '.', cover, watch, skipBuild}) { | |||
| await runTests(); | |||
|
|
|||
| if (watch) { | |||
| compiler.on('done', runTests); | |||
| compiler.on('done', () => { | |||
| runTests().catch(() => {}); // ignore error, since test output is already actionable enough | |||
There was a problem hiding this comment.
I think logging would make the test output unnecessarily noisy. The stack trace is already part of the test report
Codecov Report
@@ Coverage Diff @@
## master #64 +/- ##
==========================================
- Coverage 68.96% 68.91% -0.06%
==========================================
Files 64 64
Lines 1376 1377 +1
Branches 299 299
==========================================
Hits 949 949
- Misses 373 374 +1
Partials 54 54
Continue to review full report at Codecov.
|
|
!merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #51