Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: drop python 3.8 #66

Merged
merged 9 commits into from
Oct 25, 2024
Merged

build: drop python 3.8 #66

merged 9 commits into from
Oct 25, 2024

Conversation

tlambert03
Copy link
Member

are you ok with dropping python 3.8 @cmalinmayor? it's the only thing keeping #65 from passing, and python 3.8 is officially end of life

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.85%. Comparing base (0fdfae7) to head (f240078).
Report is 10 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (0fdfae7) and HEAD (f240078). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (0fdfae7) HEAD (f240078)
12 10
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #66       +/-   ##
===========================================
- Coverage   75.72%   60.85%   -14.88%     
===========================================
  Files          17       19        +2     
  Lines         828     1152      +324     
  Branches      154      311      +157     
===========================================
+ Hits          627      701       +74     
- Misses        136      428      +292     
+ Partials       65       23       -42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tlambert03
Copy link
Member Author

important notes for anyone paying attention to this PR: in addition to dropping python 3.8, this pr pins setuptools to <72. lots changed in that version which broke the build here, so this pin is introduced both in our build-system.requires, as well as the dev extra (which is used on ci)

@tlambert03
Copy link
Member Author

another note: i tried to support python 3.13 here, but it appears that there is no version of gurobi that yet supports 3.13 (and until #14 is resolved, we must have gurobi to build

@tlambert03 tlambert03 merged commit 404820f into funkelab:main Oct 25, 2024
15 of 16 checks passed
@tlambert03 tlambert03 deleted the drop-py3.8 branch October 25, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant