-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: drop python 3.8 #66
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #66 +/- ##
===========================================
- Coverage 75.72% 60.85% -14.88%
===========================================
Files 17 19 +2
Lines 828 1152 +324
Branches 154 311 +157
===========================================
+ Hits 627 701 +74
- Misses 136 428 +292
+ Partials 65 23 -42 ☔ View full report in Codecov by Sentry. |
important notes for anyone paying attention to this PR: in addition to dropping python 3.8, this pr pins setuptools to <72. lots changed in that version which broke the build here, so this pin is introduced both in our build-system.requires, as well as the dev extra (which is used on ci) |
another note: i tried to support python 3.13 here, but it appears that there is no version of gurobi that yet supports 3.13 (and until #14 is resolved, we must have gurobi to build |
are you ok with dropping python 3.8 @cmalinmayor? it's the only thing keeping #65 from passing, and python 3.8 is officially end of life