Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase recursion limit #65

Merged
merged 3 commits into from
Oct 25, 2024
Merged

Conversation

tlambert03
Copy link
Member

@tlambert03 tlambert03 commented Aug 12, 2024

"fixes" kinda sorta #64

well ... not really, but it's a short term workaround by increasing the recursion limit. so I'm not going to close the other issue

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.28%. Comparing base (0fdfae7) to head (4a4a1e8).
Report is 11 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (0fdfae7) and HEAD (4a4a1e8). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (0fdfae7) HEAD (4a4a1e8)
12 10
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #65       +/-   ##
===========================================
- Coverage   75.72%   61.28%   -14.44%     
===========================================
  Files          17       19        +2     
  Lines         828     1165      +337     
  Branches      154      313      +159     
===========================================
+ Hits          627      714       +87     
- Misses        136      428      +292     
+ Partials       65       23       -42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tlambert03
Copy link
Member Author

looks like this fix still fails for windows py<=3.10

@tlambert03 tlambert03 mentioned this pull request Oct 24, 2024
@tlambert03 tlambert03 changed the title fix: fix recursion limit fix: increase recursion limit Oct 25, 2024
@tlambert03 tlambert03 merged commit 1cb1994 into funkelab:main Oct 25, 2024
16 of 17 checks passed
@tlambert03 tlambert03 deleted the fix-rec branch October 25, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant