-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GroupReadsByUmi only sort input if it is not TemplateCoordinate sorted #794
Conversation
Codecov Report
@@ Coverage Diff @@
## main #794 +/- ##
==========================================
+ Coverage 95.51% 95.53% +0.01%
==========================================
Files 122 122
Lines 7063 7071 +8
Branches 500 505 +5
==========================================
+ Hits 6746 6755 +9
+ Misses 317 316 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
canTakeNextGroupByUmi
on line 480 will, I think, need updating. If the sort was done externally then I don't think we can rely on the fact that they records are also sorted by the same UMI sequence we're going to look at, and so it's not safe to take the next group by UMI.
Usage needs updating to clearly explain when sorting will and won't happen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good except for updating usage and fixing up the canTakeNextGroupByUmi
.
Done. |
33ff57b
to
86e8980
Compare
This extracts some functionality from #791, where we skip sorting the input if the input is already
TemplateCoordinate
sorted. This allows other tools to perform the sort.