Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the ParIterator in GroupReadsByUmi #791

Conversation

nh13
Copy link
Member

@nh13 nh13 commented Feb 26, 2022

@tfenne I tried updating the code to use the new ParIterator (and it also now skips sorting if the input is template-coordinate), but it seems to be all IO bound, so not sure either are worth it. Perhaps I change the PR to only keep the sorting skip. Can you take a look/run on your end?

@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2022

Codecov Report

Merging #791 (ed2ef78) into feature/group-reads-by-umi-threading (544b256) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                          Coverage Diff                          @@
##           feature/group-reads-by-umi-threading     #791   +/-   ##
=====================================================================
  Coverage                                 95.46%   95.47%           
=====================================================================
  Files                                       121      121           
  Lines                                      6864     6867    +3     
  Branches                                    453      465   +12     
=====================================================================
+ Hits                                       6553     6556    +3     
  Misses                                      311      311           
Flag Coverage Δ
unittests 95.47% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...cala/com/fulcrumgenomics/umi/GroupReadsByUmi.scala 94.27% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 544b256...ed2ef78. Read the comment docs.

@nh13 nh13 closed this Feb 28, 2022
@nh13 nh13 deleted the feature/group-reads-by-umi-threading-new-iter branch February 28, 2022 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants