Move scala-xml related code to separate module #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #610 +/- ##
==========================================
- Coverage 93.15% 93.14% -0.01%
==========================================
Files 65 67 +2
Lines 716 715 -1
Branches 10 10
==========================================
- Hits 667 666 -1
Misses 49 49
Continue to review full report at Codecov.
|
fthomas
reviewed
Feb 3, 2019
| lazy val scalaxml = myCrossProject("scalaxml") | ||
| .dependsOn(core % "compile->compile;test->test") | ||
| .settings( | ||
| libraryDependencies += "org.scala-lang.modules" %% "scala-xml" % scalaXmlVersion |
There was a problem hiding this comment.
If scala-xml is available for Scala.js and Scala Native, shouldn't this use %%%?
fthomas
reviewed
Feb 3, 2019
|
Sadly, it looks like there's no scala-xml for native: |
|
Ok, looks like this is GTG. Merge at will! |
fthomas
approved these changes
Feb 5, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure what the naming of this module should be -
scala-xml,scalaXmlorscalaxml? I tried including the hyphenated version but that seemed to cause problems in the build. Feel free to suggest an alternative to the naming and/or the package layout in the new module!Note that the
coremodule still depends onscala-xmlbecause the compiler does - see https://github.com/scala/scala-xml/wiki/FAQ