Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove xml from core #711

Closed
jhnsmth opened this issue Jan 9, 2020 · 2 comments
Closed

Remove xml from core #711

jhnsmth opened this issue Jan 9, 2020 · 2 comments

Comments

@jhnsmth
Copy link
Contributor

jhnsmth commented Jan 9, 2020

I'd like to propose removement of xml dependency from core. I believe it's there only for historical reason, as previously xml was a part of scala standard library.

Together with #647 this allows to have a single shapeless dependency in core.

If this change is welcome, I'm happy to make a PR as well as other necessary steps.
@fthomas
Copy link
Owner

fthomas commented Jan 9, 2020

This already happened in #610 which was merged into the series/0.10 branch because it is a binary and source incompatible change. I guess it is time now to merge this branch in master and to bump the version to 0.10.

@jhnsmth
Copy link
Contributor Author

jhnsmth commented Jan 9, 2020

Oh, sorry I did not know that there is a branch for upcoming version. Lets close this issue then.

@jhnsmth jhnsmth closed this as completed Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fthomas @jhnsmth