-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch to SourceLink v2 #2200
Merged
Merged
switch to SourceLink v2 #2200
Changes from 23 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
040e30c
use SourceLink v2
acca2b7
restore sln
880cb7b
msbuild 15
b792950
do not install newer dotnet core
76f174b
not a custom cotnet tToolPath
2c50bfc
msbuild restore
b10e809
RestorePackagesFlag=true
b3f831f
Restore it really
9b51328
DISABLE_NETCORE
cf81b59
restore certain projects
7760995
just Build
969a5bc
only build certain projects
0910a56
just Paket.Core
aa8b154
try 2.1.0-b439
d2cc2dc
source link for Paket.Core working
6747556
F# compiler requires full paths for embedded files
dbea0f4
turn off on travis ci
661edc9
Merge remote-tracking branch 'origin/master' into sourcelink2
87cc4bc
Microsoft.NuGet.Build.Tasks.Workaround
9b898a7
build the solution with the workaround in place
5a9d5eb
not msbuild 15 yet on mono
4cf6dba
RunIntegrationTests with embedded
cb82c5e
portable
888b74c
woraround not needed anymore
5de5ff2
Merge remote-tracking branch 'origin/master' into sourcelink2
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
os: Visual Studio 2017 | ||
init: | ||
- git config --global core.autocrlf input | ||
build_script: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
<Project> | ||
<PropertyGroup> | ||
<DebugType>portable</DebugType> | ||
</PropertyGroup> | ||
<ItemGroup> | ||
<PackageReference Include="SourceLink.Create.CommandLine" Version="2.1.0" PrivateAssets="all" /> | ||
<PackageReference Include="Microsoft.NuGet.Build.Tasks.Workaround" Version="*" PrivateAssets="all" /> | ||
</ItemGroup> | ||
</Project> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
<Project> | ||
<PropertyGroup> | ||
<BuildDependsOn>EmbedPaketFiles;$(BuildDependsOn)</BuildDependsOn> | ||
</PropertyGroup> | ||
<Target Name="EmbedPaketFiles"> | ||
<ItemGroup> | ||
<EmbeddedFiles Include="$([System.IO.Path]::GetFullPath('%(Compile.Identity)'))" | ||
Condition="$([System.String]::Copy('%(Identity)').Contains('paket-files'))" /> | ||
</ItemGroup> | ||
<CreateProperty Value="@(EmbeddedFiles)"> | ||
<Output TaskParameter="Value" PropertyName="embed" /> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This embeds the |
||
</CreateProperty> | ||
</Target> | ||
</Project> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
workaround for mixed msbuild projects like this for current MSBuild 15 NuGet/Home#4532