switch to SourceLink v2 #2200
switch to SourceLink v2 #2200
Conversation
built and released SourceLink 2.1 has SourceLink.Create.CommnadLine wrote EmbedPaketFiles target
|
It works! This is the first real F# project that I've updated to use SourceLink 2. To be meaningful, you will need to include the See http://blog.ctaggart.com/2017/03/enable-source-link-support-announcing.html |
|
Instead of |
src/Directory.Build.props
Outdated
| </PropertyGroup> | ||
| <ItemGroup> | ||
| <PackageReference Include="SourceLink.Create.CommandLine" Version="2.1.0" PrivateAssets="all" /> | ||
| <PackageReference Include="Microsoft.NuGet.Build.Tasks.Workaround" Version="*" PrivateAssets="all" /> |
There was a problem hiding this comment.
workaround for mixed msbuild projects like this for current MSBuild 15 NuGet/Home#4532
| Condition="$([System.String]::Copy('%(Identity)').Contains('paket-files'))" /> | ||
| </ItemGroup> | ||
| <CreateProperty Value="@(EmbeddedFiles)"> | ||
| <Output TaskParameter="Value" PropertyName="embed" /> |
There was a problem hiding this comment.
This embeds the paket-files in the pdb since they are not in the repository. csharp and vb support @(EmbeddedFiles) with relative directories, but not fsharp. This would work with all of them.
|
I wrote a summary of the changes. |
is fixed in Visual Studio 2017 15.1 (26403.00) https://www.appveyor.com/updates/
|
Can I get a review please? |
|
Yes will take a look at it next week after vacation. Thanks for the work. |
|
Thanks for your work! |
This is work-in-progress. It hasn't been as easy as I was hoping. The current issue is that if I try to do a
msbuild /t:build Paket.slnormsbuild /t:build Paket.fsprojafter amsbuild /t:restoreI run into this error:As far as I can tell, it has something to do with NuGet/Home#4532
Essentially, all I want to do with MSBuild 15 is:
The good news is if I limit it to just Paket.Core, it does work:
I do not know what the
unknownis. The source files aren't being checked, so F# must be doing something different then @(Compile). There is also an AccessViolation bug I'll have to troubleshoot with sourcelink test.