Skip to content
This repository has been archived by the owner on Feb 1, 2023. It is now read-only.

Improve errored job reports, bug fixes #226

Merged
merged 7 commits into from
May 26, 2017
Merged

Improve errored job reports, bug fixes #226

merged 7 commits into from
May 26, 2017

Conversation

roll
Copy link
Member

@roll roll commented May 25, 2017

@roll
Copy link
Member Author

roll commented May 26, 2017

@amercader
please take a look - it should address all problems here - https://sentry.io/open-knowledge/goodtablesio-production/searches/642098/ - and also improve how GTIO reports to users about problems

@roll roll changed the title [WIP] Improve errored job reports, bug fixes Improve errored job reports, bug fixes May 26, 2017
@roll roll requested a review from amercader May 26, 2017 14:10
Copy link
Member

@amercader amercader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @roll. I think we need to improve the way warnings are displayed in the UI but I'll create​ a new issue for this

@roll
Copy link
Member Author

roll commented May 26, 2017

@amercader
I think we anyway should let Sam at least to review our latest report changes. Of course warnings should be improved. I could do it later if it will not be covered in #187

@roll roll merged commit c799a4c into master May 26, 2017
@roll roll deleted the better-errored-job-214 branch May 26, 2017 15:22
@ppKrauss
Copy link

Hum... year or gyear?

PS: gyear triggs an error.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants