-
Notifications
You must be signed in to change notification settings - Fork 16
Design issues #187
Comments
@smth @jobarratt I marked with 🔥 what I think is more pressing |
@smth I added an item under Settings page that we forgot to include |
@smth @amercader i think the home page looks great. I've got a few small suggestions of changes below:
|
Made these changes, plus some minor ones from my own |
@amercader regarding that refresh button issue, something like http://bootstraptour.com/ might be a good solution. I would create a PR, but I'm not sure how/where to add the CSS and JS to GT. |
@amercader @jobarratt I had a chance to look at the app issues from a design perspective today, and have taken them into account to produce a revised design. I have started with the report page, as that was where most of the challenges were. Principle changes:
|
My feeling is that rather than giving users a tour the interface should tell them what to do, but happy to test it out
SASS goes to Remember to run
It looks really nice. It's worth keeping in mind that this is the source page, by default displaying the last job run. So not sure what the "Jobs" link in the sidebar would link to? Quick comments, not sure that the job history is something that needs to be always visible. Also remember that this page is accessed by non-logged in users (and those will be the majority) so the header/sidebar might look much more empty (just with logo + Sign in link), so worth keeping in mind. Good work! |
@smth
|
Mobile (picture is cropped): If screen size around 600px wide there is a green line on homepage text: I would say homepage is really good. And about an idea to have a report example on homepage (https://discuss.okfn.org/t/launching-goodtables-io-tell-us-what-you-think/5165/13?u=roll) - may be it could be a slider with changing screenshots in first screen area (current picture, picture of report etc). |
Sounds like that just needs to be renamed.
My intention was that the history panel be collapsable. Could be collapsed by default..
Yes, had thought of that. My plan is to replace the navigation items with a short introduction to GoodTables, with a link to find out more. Again, this panel could be collapsable. |
As we are using |
I've continued the conversation about the homepage in #184, to avoid this thread getting confusing. |
@smth This looks fantastic, a massive improvement and a much clearer user experience. From my point of view this looks pretty much done, just a couple of tiny things that would be great if you could work on:
I know the "Resync" flow on Manage Sources is on your mind as well. With the new design it's easier to see that it needs to be clicked if the list is empty and maybe we don't need a button but I'll leave that to you. |
@amercader Doesn't all the meaningful information on the Jobs/Sources page pertain to jobs though? A sources page would suggest to me a list of sources, which is what you find on the "Manage Sources" page. Are there any other specific places where flash messages will appear? Regarding resync, see above. I added a version containing instructions when the list isn't populated. |
I see now. The previous version of the dashboard was effectively a Sources list page, as it displayed all your sources (styled depending on the last job run on them). This is now the the "Latest jobs" on the Dashboard, and I see the See all link. TBH I think we can drop the Sources/Job page completely and just display all sources on the Last jobs column with a scroll. So there are only three pages:
Eventually we will have them on the Source page (eg "Job restarted"). I can't think of a current use case for them in the dashboard but it might come up in the future.
Ace! |
Do you think it would make sense to have "Job restarted" in the job history @amercader ? |
@smth actually if the job restarts the whole report should be removed and we could display a message there. This is actually not going to be implemented any time soon, so don't worry about it for now. The important messages were the Manage Sources page ones, which look great. |
@smth do you think we could make goodTables.io -> goodtables.io ? If this was conscious and you think it is better as is now then ok. |
It was conscious, I like the way it breaks up the words. I'm not completely opposed to changing it though. What's your reasoning @pwalsh ? |
The "official" name has been goodtables.io so far and is consistent with the library name so I'm +1 on the lower case |
@smth just that it "feels" better to me. |
OK, logo will be updated in the new version http://p.smth.uk/goodtables/dashboard/ |
Removing myself from this issue, in favour of the below (let me know if I'm missing anything). |
Catch-all issue with minor design things that I can't fix but that will be no problem for @smth (or maybe @roll)
Layout
Header
visual design including logo (:fire:)Home page
Dashboard page
Can't get to show 4 columns (or 3 centered) (:fire:)
Source names overflow if columns are too small
see prev picture - bottom side is not really clickable but mouse is a pointer on hovering
icon-warning
not displaying properlySource page
Tone down green / red / yellow on the top banner (:fire:)
Valid files background color
Add horizontal scrolling to error groups
Close popups on next click (
data-trigger="focus"
) - hide the wholei
button for beta??? We don't have enough imformation to show here.In report filename is a link but it much wider than actual text. So clicking in the middle of the page could lead to link click
in report errors we don't show headers for non-header (in-rows) errors (but we should!)
we show only first 10 errors of error type - review UI/X for saying that output is trancated
proper
Jobs History
visual design (a tab on/source
page) (:fire:)on small screen there is a problem with text color:
Report/Job history
should use anchor like#job-history
to make browser back button to work correctlySettings page
/settings
page - visual design just a bad copy from what we had in three-column layout (:fire:)The text was updated successfully, but these errors were encountered: