-
Notifications
You must be signed in to change notification settings - Fork 16
Report UI Design #268
Comments
Report component (part of the picture above with file names and error lists) now lives in the dedicated repository:
It's a very important component because it provides UI for various OKI services:
Because it's a re-usable component we have slightly different tech requirements for CSS e.g. we can't use bootstrap variables and can't directly tweak bootstrap classes (only prefixing with Because we're updating report visual design again I'm wondering is it possible for you @smth to work directly on https://github.com/frictionlessdata/goodtables-ui codebase? It easy to work with and could simplify things. cc @smth @amercader PS. |
OK, so as a first step, I have extracted the report SCSS (as it stands) into a separate file, and given it its own variables, so it can be more easily tweaked and/or generated outside of Bootstrap. https://github.com/smth/goodtables/blob/master/assets/scss/goodtables-ui-report.scss Is this the approach you had in mind? |
@roll @amercader what do / can we show in a report that has no errors? |
Thanks. I think it should solve many problems of |
I think it's definitely a list of valid file names. What we have also (may be as a click on show more details):
|
OK, I've added a passed file name, as well as the ability to see passed tests for each file: http://p.smth.uk/goodtables/jobs/report/ Do we think this is sufficient? |
@smth |
DONE |
Provide a list of errors/failures for job. Describe nature of error, make it easy to find in original file(s).
Show history of jobs for current source.
The text was updated successfully, but these errors were encountered: