Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add patterns #331

Merged
merged 3 commits into from
Dec 20, 2016
Merged

Add patterns #331

merged 3 commits into from
Dec 20, 2016

Conversation

@pwalsh pwalsh self-assigned this Dec 11, 2016
@pwalsh
Copy link
Member Author

pwalsh commented Dec 11, 2016

@jheeffer see bef39e8

Would you mind contributing your concrete proposal for translations to the section I added for it? I tried to do it myself but I encountered various cases that I was not sure how you guys handle, or perhaps how they should be worded (remote/local).

@rufuspollock
Copy link
Contributor

@pwalsh BTW I'm increasingly feeling we should call this section FAQs and Patterns even if url remains patterns of whatever. I think people know what an FAQ is and a bunch of stuff will be more faq like. I think patterns as solutions to (bigger) FAQs make sense so having both in naming is ok.

@pwalsh
Copy link
Member Author

pwalsh commented Dec 11, 2016

@rufuspollock no problem on FAQs. Any other comments before we can merge this>


## Specification

On any Frictionless Data descriptor, data that is not generated by the author/contributors, but is generated by software/a system handling the data, `SHOULD` be considered as "private", and be prefixed by an underscore `_`.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"data" here is a bit confusing. I initially thought it talks about the csv or other data placed in resources.

@jheeffer
Copy link

jheeffer commented Dec 12, 2016

@pwalsh I'd be glad to contribute, but I have two solutions

  1. The way I proposed in the translations PR Proposal: Translation and Language Support in JSON Table Schema #190 (comment)
    This is generic and supports both your inline as well as a filesystem based solution. It is however pretty verbose (and also needs an extra pair of eyes to check if it's totally unambiguous).

  2. The way we store translations in our datasets at Gapminder (datapackage.json and translations folder and documentation). Has assumptions on location and format of translation files (like your inline solution does) and thus is not generic, but also a lot less verbose.

Which one are you interested in?

@pwalsh
Copy link
Member Author

pwalsh commented Dec 12, 2016

@jheeffer definitely solution 2. Thank you!

@rufuspollock
Copy link
Contributor

@pwalsh i'd like to get this merged asap so we have less outstanding and because this is an item with no impact on specs (it is not changing anything).

wdyt?

@pwalsh
Copy link
Member Author

pwalsh commented Dec 19, 2016

@rufuspollock I'm happy for it to be merged now, and then @jheeffer can do his PR against the default branch

@pwalsh pwalsh changed the title [WIP] add patterns Add patterns Dec 19, 2016
@rufuspollock
Copy link
Contributor

@pwalsh merging now.

@jheeffer be great to get your pattern in here for how you handle translations as per your option 2. Just do a PR as soon as you are ready:

  1. The way we store translations in our datasets at Gapminder (datapackage.json and translations folder and documentation). Has assumptions on location and format of translation files (like your inline solution does) and thus is not generic, but also a lot less verbose.

@rufuspollock rufuspollock merged commit 4766869 into gh-pages Dec 20, 2016
@jpmckinney jpmckinney deleted the feature/patterns branch December 20, 2016 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants