Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't mark notifications as read #93

Closed
mmoayyed opened this issue Apr 10, 2020 · 4 comments
Closed

Can't mark notifications as read #93

mmoayyed opened this issue Apr 10, 2020 · 4 comments
Labels

Comments

@mmoayyed
Copy link

Browser console (Chrome: 80.0.3987.163 (Official Build) (64-bit)), upon clicking on the notification icon shows:

github-notifications-preview.js:538 Uncaught (in promise) TypeError: {} is not a function

See:
image

And:
image

Plugin Version: 20.4.5

PS Happy to submit a PR if I can.

@tanmayrajani
Copy link
Collaborator

Hi, thank you for submitting the issue.

As you might know, we have recently worked to have very minimal support of beta notifications, all thanks to @fregante. Marking as read might not be supported just yet but hopefully we will get it to work in a near future. Feel free to contribute if you can 🥂

@mmoayyed
Copy link
Author

Thanks very much. I appreciate note, and will take a look to see if I might be able to provide a fix.

@fregante fregante added the bug label Apr 10, 2020
@fregante fregante changed the title Error: Uncaught (in promise) TypeError: {} is not a function Can't mark notifications as read Apr 10, 2020
@fregante
Copy link
Owner

Indeed, the whole listener is build around the old notifications UI and needs to be rewritten for the new notifications.

@fregante
Copy link
Owner

This feature has been dropped for now. Moving issue to #94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants