-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't mark notifications as read #93
Comments
Hi, thank you for submitting the issue. As you might know, we have recently worked to have very minimal support of beta notifications, all thanks to @fregante. Marking as read might not be supported just yet but hopefully we will get it to work in a near future. Feel free to contribute if you can 🥂 |
Thanks very much. I appreciate note, and will take a look to see if I might be able to provide a fix. |
Indeed, the whole listener is build around the old notifications UI and needs to be rewritten for the new notifications. |
This feature has been dropped for now. Moving issue to #94 |
Browser console (Chrome: 80.0.3987.163 (Official Build) (64-bit)), upon clicking on the notification icon shows:
github-notifications-preview.js:538 Uncaught (in promise) TypeError: {} is not a function
See:
And:
Plugin Version: 20.4.5
PS Happy to submit a PR if I can.
The text was updated successfully, but these errors were encountered: