-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore "Mark as read" #94
Comments
Should add both the "Done" and "Unsubscribe" buttons present on the notifications page. |
It appears that if we load the missing script on the page, this will start working without extra JS code. Missing script: https://github.githubassets.com/assets/notifications-v2-bootstrap-9ab1c3e0.js We can get this URL from the notifications page and inject it only once the user opens the dropdown. The second part of this issue would be to restore the buttons via CSS and fix their position/size/spacing (smaller and more compact) |
I've opened a PR, please take a look. |
This got implemented in #98. Closing. |
The feature was dropped in 606d022#diff-ee206f3e88c066917fc8b643bf8fa7a6 because it's incompatible with the new Notifications style and the button itself needs better CSS.
Help wanted to restore this feature.
Moved from #93
The text was updated successfully, but these errors were encountered: