Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore "Mark as read" #94

Closed
fregante opened this issue Apr 22, 2020 · 4 comments
Closed

Restore "Mark as read" #94

fregante opened this issue Apr 22, 2020 · 4 comments

Comments

@fregante
Copy link
Owner

fregante commented Apr 22, 2020

The feature was dropped in 606d022#diff-ee206f3e88c066917fc8b643bf8fa7a6 because it's incompatible with the new Notifications style and the button itself needs better CSS.

Help wanted to restore this feature.

Moved from #93

@fregante fregante modified the milestones: Full New Notifications support, New Notifications Apr 22, 2020
@silverwind
Copy link
Contributor

Should add both the "Done" and "Unsubscribe" buttons present on the notifications page.

@fregante
Copy link
Owner Author

fregante commented May 19, 2020

It appears that if we load the missing script on the page, this will start working without extra JS code.

Missing script: https://github.githubassets.com/assets/notifications-v2-bootstrap-9ab1c3e0.js

We can get this URL from the notifications page and inject it only once the user opens the dropdown.

The second part of this issue would be to restore the buttons via CSS and fix their position/size/spacing (smaller and more compact)

@mallowigi
Copy link
Contributor

I've opened a PR, please take a look.

@tanmayrajani
Copy link
Collaborator

This got implemented in #98. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants