-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finish transition to new Notifications #89
Comments
I've noticed the following with the new version, regarding the #57 feature: (Tested extension 20.4.5 in a fresh Chrome 81 profile) Screenshot comparison having |
Please open a new issue if it's still broken. I'll mark this as done due to https://github.com/tanmayrajani/notifications-preview-github/releases/tag/20.4.22 |
I see that the new version, 20.4.22, is available only in Firefox AMO. And, I've tested the Firefox version, and the counter in the bubble is still broken if I enable |
This is due to #91 |
Thanks for the info. |
They started requesting more information lately, so every old extension is stuck until we add the information. It happened to my other 3 extensions I updated recently. |
Thank you for the quick response. I'm glad the new version is now in CWS as well. I opened a new issue here: #95 |
#81 added support for the new Notifications in the least intrusive way possible, but the CSS is almost entirely outdated and the JS still has some references to DOM that no longer exists.
#57 could be considered
The text was updated successfully, but these errors were encountered: