Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish transition to new Notifications #89

Closed
4 of 5 tasks
fregante opened this issue Apr 4, 2020 · 8 comments
Closed
4 of 5 tasks

Finish transition to new Notifications #89

fregante opened this issue Apr 4, 2020 · 8 comments
Labels

Comments

@fregante
Copy link
Owner

fregante commented Apr 4, 2020

#81 added support for the new Notifications in the least intrusive way possible, but the CSS is almost entirely outdated and the JS still has some references to DOM that no longer exists.

#57 could be considered

@fregante fregante added the bug label Apr 4, 2020
@darkred
Copy link
Contributor

darkred commented Apr 9, 2020

I've noticed the following with the new version, regarding the #57 feature:
and thought to post it here, instead of opening a new issue

(Tested extension 20.4.5 in a fresh Chrome 81 profile)
if I enable Show only participating notifications then the notification number in the bubble is no longer displayed, even if Show notification number in blue bubble remains enabled.

Screenshot comparison having Show only participating notifications :

Disabled --> bubble number is ok

2020-04-09_121059

Enabled --> bubble number is missing

2020-04-09_121150

@fregante
Copy link
Owner Author

Please open a new issue if it's still broken. I'll mark this as done due to https://github.com/tanmayrajani/notifications-preview-github/releases/tag/20.4.22

@fregante
Copy link
Owner Author

If you enable GitHub’s "Group by repository" option, the extension now exactly looks like it used to 🎉

option

grouped

While the new style is this, cleaned up:

ungrouped

@darkred
Copy link
Contributor

darkred commented May 1, 2020

Please open a new issue if it's still broken. I'll mark this as done due to 20.4.22 (release)

I see that the new version, 20.4.22, is available only in Firefox AMO.
In CWS it's still 20.4.5. Maybe it's stuck at pending review ?

And, I've tested the Firefox version, and the counter in the bubble is still broken if I enable Show only participating notifications. Is it ok if I open a new issue based only on the Firefox version?

@fregante
Copy link
Owner Author

fregante commented May 1, 2020

This is due to #91

@darkred
Copy link
Contributor

darkred commented May 1, 2020

Thanks for the info.
The review procedure in CWS is still so awful for the developers..

@fregante
Copy link
Owner Author

fregante commented May 1, 2020

They started requesting more information lately, so every old extension is stuck until we add the information. It happened to my other 3 extensions I updated recently.

@darkred
Copy link
Contributor

darkred commented May 1, 2020

Thank you for the quick response. I'm glad the new version is now in CWS as well.

I opened a new issue here: #95

Repository owner locked and limited conversation to collaborators Aug 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants